Testing 27/01/25

[DominicOram]

• Group of full collections
• Changing energy between collections
• S+C

[DominicOram]

Close #703 is this looks fixed

[DominicOram]

• S+C wasn't setting the screen to be a characerisation, this is because GDA wasn't passing it through, fixed on the beamline - see Screen and collect screens but subsequent collections are not made #703 (comment)
• Error of RuntimeError: Another set() call is still in progress for eiger_cam_roi_mode - think this is because disarm isn't waiting on disable roi - Fixed in Fix errors from testing mx_bluesky dodal#1036
• For S+C we need to collect even if there has been no chi or sample change. Hacked a fix for this on the beamline - Will be fixed in Hyperion: If there is no need to center then collect at current co-ordinates #791
• Issue on https://ispyb.diamond.ac.uk/dc/visit/mx23694-127/dcg/13866244 where it took another collection at 0, 0, 0 after the first. This is wrong, not sure why. - this was due to the hack for Hyperion: If there is no need to center then collect at current co-ordinates #791. Will be fixed properly in that issue

[DominicOram]

Still getting the final issue https://ispyb.diamond.ac.uk/dc/visit/mx23694-127/id/16607686 - due to the hack in #791, will be fixed properly as part of that issue

[DominicOram]

For #505 the error is actually reported on BL03I-MO-ROBOT-01:CNTL_ERR_CODE not BL03I-MO-ROBOT-01:PRG_ERR_CODE. We should be logging both error PVs. We should also log when we do the reset - fixed in DiamondLightSource/dodal#1036

[DominicOram]

We also had an issue where we were arming synchronously as we're calling @bpp.stage_decorator([eiger]). The asynchronous arm is wrapped in start_preparing_data_collection_then_do_plan. There is a fix on the beamline for this - proper fix in DiamondLightSource/dodal#1036

[DominicOram]

For S+C we need to collect even if there has been no chi or sample change. Hacked a fix for this on the beamline

#791 for follow up