Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from testing #796

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Feb 4, 2025

Fixes #769

Requires changes from DiamondLightSource/dodal#1036

To test:

  • Confirm tests pass
  • Confirm all problems noted in issue are covered by this PR or other new issues

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (b13a68b) to head (e0e8b37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   87.01%   87.01%   -0.01%     
==========================================
  Files         101      101              
  Lines        6970     6967       -3     
==========================================
- Hits         6065     6062       -3     
  Misses        905      905              
Components Coverage Δ
i24 SSX 72.84% <ø> (ø)
hyperion 96.54% <100.00%> (-0.01%) ⬇️
other 96.58% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing 27/01/25
1 participant