Clean up order of deploying #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage 86.44% 86.44%
=======================================
Files 102 102
Lines 6937 6937
=======================================
Hits 5997 5997
Misses 940 940
|
DominicOram
requested review from
rtuck99,
noemifrisina,
d-perl and
olliesilvester
noemifrisina
approved these changes
Dec 2, 2024
rtuck99
force-pushed
the
692_fixes_from_testing
branch
from
835f749 to
e3230d2
Compare
rtuck99
reviewed
Dec 3, 2024
| @@ -53,5 +53,5 @@ For building and deploying a Docker image please see :doc:`../../hyperion/deploy | |||
| .. code:: console | |||
|
|
|||
| . ./.venv/bin/activate | |||
| pip install -e . | |||
| pip install -e ../dodal | |||
There was a problem hiding this comment.
This is wrong and will result in the reverse of what you want.
If you pip install -e ., this will install an editable version of mx-bluesky from the local git folder, however it will also install a non-editable version of dls-dodal from pypi, overriding the editable version previously installed
Because our deployments are based on editable versions of the folder, we want to install mx-bluesky first and dls-dodal second.
|
PR rejected due to above reasoning |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##692
To test: