Update MX beamlines to use new device factory - Part 1 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 101 101
Lines 6968 6970 +2
=======================================
+ Hits 6063 6065 +2
Misses 905 905
|
|
Need to update beamline for |
olliesilvester
changed the title
rtuck99
changed the title
rtuck99
force-pushed
the
dodal_846_update_mx_beamlines_to_use_device_factory
branch
2 times, most recently
from
b1b8a49 to
a16bb7f
Compare
This was referenced Jan 13, 2025
olliesilvester
approved these changes
Jan 17, 2025
|
|
||
|
|
||
| @pytest.fixture(scope="function", autouse=True) | ||
| def clear_device_factory_caches_after_every_test(i03_device_factories): |
There was a problem hiding this comment.
Do you think something similar would be useful in dodal?
There was a problem hiding this comment.
Seems like dodal follows a different pattern for unit test fixtures - rather than have global fixtures using device_instantiation seems to mostly be one-off constructions of devices, thus far it doesn't seem to have been necessary.
Ignore that - I forgot that I did eventually add it in dodal as well
rtuck99
force-pushed
the
dodal_846_update_mx_beamlines_to_use_device_factory
branch
2 times, most recently
from
33b17f6 to
68bb897
Compare
rtuck99
force-pushed
the
dodal_846_update_mx_beamlines_to_use_device_factory
branch
from
68bb897 to
28f6ac7
Compare
rtuck99
deleted the
dodal_846_update_mx_beamlines_to_use_device_factory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses
See also dodal PR
Additionally, this PR also adds unit test duration summary to the end of pytest, this was done because it seems that tests are taking longer, see related issue that is not addressed here
setup_context()unexpected behaviour dodal#973