-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it clear to a user that we're skipping collections after blank XRC #814
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
=======================================
Coverage 86.94% 86.94%
=======================================
Files 102 102
Lines 6968 6972 +4
=======================================
+ Hits 6058 6062 +4
Misses 910 910
|
I assigned the conftest runstop event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test. As discussed, I think there's a cleaner solution
src/mx_bluesky/common/external_interaction/callbacks/xray_centre/ispyb_callback.py
Outdated
Show resolved
Hide resolved
reason = doc.get("reason") or "" | ||
if "CrystalNotFoundException" in reason: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should: As discussed, checking strings is bad, we can use type_and_message_from_reason
here I think
Yep, this is fine, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Much cleaner than my hotfix. Optional change, take it or leave it.
Fixes issue #784
Added the hotfix @DominicOram wrote in the beamline deployment, and a unit test to test the ispyb callback stop event.