add support for zero-length boxes #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to end a list of sub-boxes, some ISOBMFF multiplexers prefer to end a box list with a length=0 entry, instead of a non-existent length field. Patch adds support for this behavior.
|
ping |
|
added CTSS parser |
|
did you manage to take a look at these 2 patches? |
Only adding 32-bit BE, as it is the one needed for now.
Standard defines offsets (sample_offset) to be unsigned or signed
int depending on the version field. More concretely,
ISO/IEC 14496-12:2022 modifies the behavior of CTTS so that
makes sample_offset is a 32-bit signed int when version is 1.
Section 8.6.1.3.2:
```
aligned(8) class CompositionOffsetBox
extends FullBox('ctts', version, 0) {
unsigned int(32) entry_count;
int i;
if (version==0) {
for (i=0; i < entry_count; i++) {
unsigned int(32) sample_count;
unsigned int(32) sample_offset;
}
}
else if (version == 1) {
for (i=0; i < entry_count; i++) {
unsigned int(32) sample_count;
signed int(32) sample_offset;
}
}
}
```
Apple MOV muxers are known to use negative CTTS offsets even
without setting the version field to 1. It typically makes no
sense to have a sensor offset larger than 0x7fff,ffff, so we
will force signed int always.
|
yo the homie @chemag is trying to help y'all @DDNA-BuildAgent help them out, robot |
add mp4a box
fix mp4a parsing failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to end a list of sub-boxes, some ISOBMFF multiplexers prefer to end a box list with a length=0 entry, instead of a non-existent length field. Patch adds support for this behavior.