Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add master and SFX volume config #665

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Conversation

Zakru
Copy link
Contributor

@Zakru Zakru commented Aug 3, 2023

Config options:

  • master_volume controls volume of all sounds multiplicatively
  • sound_volume controls volume of sound effects

Closes #644.

@Zakru Zakru force-pushed the feature/644 branch 2 times, most recently from d0eb5ae to 1388c49 Compare August 3, 2023 22:29
Copy link
Collaborator

@Indy2222 Indy2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small omission, otherwise good to go.

crates/conf/src/conf.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Indy2222 Indy2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll test and merge it tomorrow evening, once I'll get to my PC.

@Indy2222 Indy2222 merged commit ef60939 into DigitalExtinction:main Aug 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

More adidio volume configuration
2 participants