- Reverted changes that broke /weaksecurity

- Bumped version to 1.0.5.7
DigitalMediaServer · Mar 31, 2022 · 447625a · 447625a
1 parent af4dd9d
commit 447625a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/Contrib/Inetc/inetc.cpp b/Contrib/Inetc/inetc.cpp
@@ -136,6 +136,9 @@
 *              Created /NOSSL option that prevents redirects to HTTPS (which breaks Windows XP)
 *     Sep 24, 2018 - 1.0.5.6 - anders_k
 *              /tostackconv supports UTF-8 and UTF-16LE BOM sniffing and conversion.
+*     Mar 31, 2022 - 1.0.5.7 
+*              Fixed download progress for files larger than 2 GB (pjpuchyr)
+*              Reverted changes that broke /weaksecurity in 1.0.5.5
 *******************************************************/
 
 
@@ -185,7 +188,7 @@ FTP_CMD myFtpCommand;
 #define PROXY_AUTH_HDR TEXT("Proxy-authorization: basic %s")
 
 //#define MY_WEAKSECURITY_CERT_FLAGS SECURITY_FLAG_IGNORE_UNKNOWN_CA | SECURITY_FLAG_IGNORE_REVOCATION | SECURITY_FLAG_IGNORE_CERT_DATE_INVALID | SECURITY_FLAG_IGNORE_CERT_CN_INVALID
-#define MY_WEAKSECURITY_CERT_FLAGS INTERNET_FLAG_IGNORE_CERT_CN_INVALID | INTERNET_FLAG_IGNORE_CERT_DATE_INVALID | INTERNET_FLAG_IGNORE_REDIRECT_TO_HTTP
+#define MY_WEAKSECURITY_CERT_FLAGS SECURITY_FLAG_IGNORE_UNKNOWN_CA | SECURITY_FLAG_IGNORE_REVOCATION
 #define MY_HTTPS_FLAGS (INTERNET_FLAG_IGNORE_REDIRECT_TO_HTTPS | INTERNET_FLAG_SECURE)
 
 enum STATUS_CODES {

diff --git a/Contrib/Inetc/inetc.rc b/Contrib/Inetc/inetc.rc
@@ -186,8 +186,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 1,0,5,6
- PRODUCTVERSION 1,0,5,6
+ FILEVERSION 1,0,5,7
+ PRODUCTVERSION 1,0,5,7
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -203,12 +203,12 @@ BEGIN
         BLOCK "040904b0"
         BEGIN
             VALUE "FileDescription", "inetc NSIS plug-in"
-            VALUE "FileVersion", "1.0.5.6"
+            VALUE "FileVersion", "1.0.5.7"
             VALUE "InternalName", "inetc.dll"
             VALUE "LegalCopyright", "Copyright � Takhir Bedertdinov"
             VALUE "OriginalFilename", "inetc.dll"
             VALUE "ProductName", "inetc NSIS plug-in"
-            VALUE "ProductVersion", "1.0.5.6"
+            VALUE "ProductVersion", "1.0.5.7"
         END
     END
     BLOCK "VarFileInfo"

diff --git a/README.md b/README.md
@@ -3,6 +3,8 @@
 The [INetC (Internet client) plug-in][1] is a [NSIS][2] plugin downloading and uploading files. It is based on the 
 [InetLoad plug-in][4]. The network implementation uses `MS WinInet API`, and supports the `HTTP`, `HTTPS` and `FTP` protocols.
 
+**Note:** There are some unfortunate issues with `MS WinInet API`, as it is based on using parts of the long abandoned Internet Explorer. This means that IE users settings (Proxy settings etc.) will apply to this plugin as well. In addition, it's not exactly up-to-date in many respects - and it will only support TLS 1.1 on Windows XP for example. There now exists an alternative plugin [NSCurl](https://github.com/negrutiu/nsis-nscurl) that uses [libcurl](https://curl.haxx.se/libcurl/) and [OpenSSL](https://www.openssl.org/) instead of `WinInet`. While I haven't personally tried it, this might be a better solution for many.
+
 [NSIS (Nullsoft Scriptable Install System)][2] is a professional open source system to create Windows installers.
 It is designed to be as small and flexible as possible and is therefore very suitable for internet distribution.
 
@@ -16,6 +18,7 @@ Changes in this fork are:
 * **1.0.5.4** - Created a 4th download dialog `/MODERNPOPUP`
 * **1.0.5.5** - Created option `/NOSSL` which prevents redirects from HTTP to HTTPS
 * **1.0.5.6** - Applied changes from upstream `1.0.5.3`: `/tostackconv` supports UTF-8 and UTF-16LE BOM sniffing and conversion.
+* **1.0.5.7** - Fixed download progress for files larger than 2 GB (thanks @pjpuchyr) and reverted changes that broke `/WEAKSECURITY`.
 
 Nadahar