Skip to content

Commit

Permalink
refactor: remove unnecessary if and document calls
Browse files Browse the repository at this point in the history
#
# Hier eventueel een uitleg over de wijziging ten op zichte van de
# vorige versie max. 72 tekens per regel.
#
# Eventuele breaking changes hier vermelden en ook verwijzingen naar
# tickets en andere resources.
# Jira #WST-123
# Zie ook: http://podio.com/webstores/klant/stories/432
  • Loading branch information
Dion Potkamp committed Dec 11, 2019
1 parent 06228b0 commit dc137bd
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions game.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ let autoPlayI = 0;
/** array of all possible players */
let players = ['X', 'O'];
let CurrentPlayer = setNewPlayer();
document.getElementById('text').innerHTML = 'Starting player is: ' + CurrentPlayer;
let textElement = document.getElementById('text');
textElement.innerHTML = 'Starting player is: ' + CurrentPlayer;

/** using font awesome to draw the X and O */
let PlayerX = '<i class="fas fa-times"></i>';
Expand All @@ -99,11 +100,11 @@ function switchPlayer() {
return false;
} else if (CurrentPlayer === "X") {
CurrentPlayer = "O";
document.getElementById('text').innerHTML = "Current player is " + CurrentPlayer;
textElement.innerHTML = "Current player is " + CurrentPlayer;
return true;
} else if (CurrentPlayer === "O") {
CurrentPlayer = "X";
document.getElementById('text').innerHTML = "Current player is " + CurrentPlayer;
textElement.innerHTML = "Current player is " + CurrentPlayer;
return true;
} else {
return false;
Expand Down Expand Up @@ -211,7 +212,7 @@ function drawWin(type, cell) {
document.getElementById(value).style.color = 'rgb(128, 128, 128)';
}

document.getElementById('text').innerHTML = "Draw!";
textElement.innerHTML = "Draw!";
return true;
}
return false;
Expand Down Expand Up @@ -310,7 +311,7 @@ function restartGame() {
} else if(winner === 'O') {
CurrentPlayer = 'X';
}
document.getElementById('text').innerHTML = 'Starting player is: ' + CurrentPlayer;
textElement.innerHTML = 'Starting player is: ' + CurrentPlayer;

winner = null;

Expand Down Expand Up @@ -346,9 +347,7 @@ function resetScores() {
* @return void, to stop the function.
*/
function coreAutoPlay() {
if (isAutoPlaying) {
return;
} else {
if (!isAutoPlaying) {
isAutoPlaying = true;
autoPlay();
}
Expand Down

0 comments on commit dc137bd

Please sign in to comment.