Add a root html element in Dioxus integration #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfraz89
changed the title
cfraz89
changed the title
nicoburns
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
We'll want to think this through properly at some point (I suspect we may want to align Blitz so that the same code can easily be used across Blitz and other other dioxus platforms, which may involve synthesising both <html> and <body>). But I reckon this is better than we have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81 - Currently, dioxus apps without a single root element crash when rendered in blitz. This fixes that by creating a virtual
<html>root element.I experimented with a couple of other approaches as well, such as:
So this way seemed to be the best way to make it work out. With this fix you should find that the dioxus examples such as
bare_styleandtailwindno longer crash, and render correctly as far as they can.