Port full gradient support to blitz #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Ah amazing. I was hoping that you would revive that PR! I am not able to verify the math, but this seems to fix the rendering of the linear gradient on servo.org (it now matches chrome), and even an incorrect rendering of the radial and conic gradients will be much better than what we currently have (which panics!), so I'm happy to trust that it is correct :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revives the long-stalled PR from jkelleyrtp/stylo-dioxus#4.
It adds full gradient support. Note that due to Vello's behavior, it follows the SVG schema rather than the web schema by default ("transparent" is #00000000 rather than #FFFFFF00 in color mixing), so some gradients may differ.