Checkbox internal state #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps checkbox checked value internally in
NodeSpecificData, instead of setting thecheckedattribute on the node. This more closely aligns it with the w3c spec.In addition, as the checked property in rsx is now interpreted specially instead of being forwarded directly to the attribute, it can now handle boolean values as well as strings, such that
checked: checkbox_checked(),rsx now works.Last of all the 'value' property of formevent now reflects the checked state instead of the value attribute of the checked element, aligning it with dioxus web, and ensuring that FormEvent.checked() is correct.