Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Fix default_constructed_unit_structs warning. #48

Merged
merged 1 commit into from
Aug 3, 2023
Merged

clippy: Fix default_constructed_unit_structs warning. #48

merged 1 commit into from
Aug 3, 2023

Conversation

waywardmonkeys
Copy link

This warning is new in 1.71.

@waywardmonkeys
Copy link
Author

I just fixed the warning, figuring that Config will one day more than a unit struct and shouldn't just be removed.

@waywardmonkeys waywardmonkeys mentioned this pull request Jul 23, 2023
Merged
@waywardmonkeys
Copy link
Author

This would fix the CI check that fails currently.

ealmloff
ealmloff approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I must have missed this when you originally made the PR. Yes, in the future Config will not be a unit struct

@ealmloff ealmloff merged commit ca977df into DioxusLabs:master Aug 3, 2023
7 checks passed
@waywardmonkeys waywardmonkeys deleted the fix-clippy-1.71 branch August 3, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @ealmloff