Use grid area size not available space when applying aspect ratio to grid containers #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
force-pushed
the
grid-aspect-ratio-area-size-not-available-space
branch
from
c778403
to
fb37fb6
Compare
…atio to grid items
nicoburns
force-pushed
the
grid-aspect-ratio-area-size-not-available-space
branch
from
fb37fb6
to
be60ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix an issue surfaced by the linked test in #653.
Specifically a grid area may have a defined size even when the available space for the grid does not (for example if the grid container has fixed pixel sizing).