Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix description in traits.rs #731

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix description in traits.rs #731

merged 2 commits into from
Nov 4, 2024

Conversation

tistatos
Copy link
Contributor

Objective

Missed to update the documentation in traits.rs in #730

Feedback wanted

For my own understanding and for others clarification, I also added the reason why this example is limited to TraversePartialTree - Hopefully it's correctly described!

Copy link
Collaborator

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not wrong, but I don't think it will make sense to people reading that part of the docs (who may well not know what TraversePartialTree is). Perhaps this would make more sense as a doc comment in the example itself?

@tistatos
Copy link
Contributor Author

That is a valid point! I will add it to the example. Would you like me to add it at the head of the file? Or in connection with the impl TraversePartialTree ?

@nicoburns
Copy link
Collaborator

I think at the head of the file would make most sense.

@nicoburns nicoburns merged commit a166049 into DioxusLabs:main Nov 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants