Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typing): support Object category in create_x_channel #1163

Merged
merged 4 commits into from
Mar 19, 2024
Merged

fix(typing): support Object category in create_x_channel #1163

merged 4 commits into from
Mar 19, 2024

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Mar 2, 2024

Summary

fixes #1162.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added p: low Low priority t: refactor/typing/lint Refactors, typing changes and/or linting changes t: bugfix labels Mar 2, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Mar 2, 2024
@shiftinv shiftinv merged commit 227ec80 into master Mar 19, 2024
27 checks passed
@shiftinv shiftinv deleted the fix/typing-create-channel-category branch March 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: low Low priority t: bugfix t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

Inconsistency with type hinting create_x_channel methods and underlying _create_channel method
1 participant
@shiftinv