Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support banner parameter in ClientUser.edit #1165

Merged
merged 3 commits into from
Apr 15, 2024
Merged

feat: support banner parameter in ClientUser.edit #1165

merged 3 commits into from
Apr 15, 2024

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Mar 15, 2024 •
edited
Loading

Summary

discord/discord-api-docs#6710

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Mar 15, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Mar 15, 2024
@shiftinv shiftinv marked this pull request as ready for review March 26, 2024 14:50
@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Apr 15, 2024
@shiftinv
Copy link
Member Author

api docs still aren't merged (:/), but given that this was officially announced a while ago, this should be good to go.

@shiftinv shiftinv merged commit 5e2ced2 into master Apr 15, 2024
28 of 30 checks passed
@shiftinv shiftinv deleted the feature/bot-banner branch April 15, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.
1 participant
@shiftinv