Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Examples Hyperlink Fix #1166

Merged
merged 2 commits into from
Mar 17, 2024
Merged

fix: Examples Hyperlink Fix #1166

merged 2 commits into from
Mar 17, 2024

Conversation

OseSem
Copy link
Contributor

@OseSem OseSem commented Mar 17, 2024

Summary

In README.md the you can find more examples in the examples directory. In PyPi the hyperlink will redirect you to https://pypi.org/project/disnake/examples/ instead of https://github.com/DisnakeDev/disnake/tree/master/examples. This will fix it by adding that url.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@OseSem OseSem changed the title Examples Hyperlink Fix fix: Examples Hyperlink Fix Mar 17, 2024
@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples t: bugfix labels Mar 17, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Mar 17, 2024
@shiftinv shiftinv enabled auto-merge (squash) March 17, 2024 14:19
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@shiftinv shiftinv merged commit 17b741a into DisnakeDev:master Mar 17, 2024
31 of 34 checks passed
shiftinv pushed a commit that referenced this pull request May 18, 2024
This is required for it to link properly outside of GitHub, like PyPI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: bugfix t: documentation Improvements or additions to documentation/examples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants