SOV-4316 upgradeable contract

[cwsnt]

No description provided.

[tjcloa]

• https://github.com/DistributedCollective/sovryn-lb-dex/blob/SOV-4316-upgradeable-contract/src/LBPair.sol#L80
We don’t need this variable in the LBPair logic contract - it comes from the Clone contract but we don’t use Clone contract, so pls remove it from the import too
• According to the ticket #SOV-4316 the contracts should be upgradable using OZ transparent upgradeable pattern, pls refer to: https://docs.openzeppelin.com/upgrades-plugins/1.x/foundry-upgrades#examples
• also see inline code comments

[tjcloa]

another round of review completed.
after addressing new comments, we should be good to go.
apart from the code comments:

1. the compiler is complaining on the unused param Version in the function _getLBPairInformation - pls remove it.
2. according to the foundry docs vm.createSelectFork will not work for deployment on live chains but on a fork
   if using --chain as a param then no need to change network - it will be used in the script it under the hood.
   block.chainid can be used in the script to identify which deployment config is required.
   if you want to switch networks the right way seems to set the chainId via vm.chainId(60808) .
   update:
   it will work, but still confusing and not clear why setting a fork does deployment on a live chain, could be an issue with foundry, so using vm.chainid is more appropriate, but leaving it to you to decide on that.

[koirikivi]

Overall good stuff!

Some changes requested, mostly about git related stuff (there's a ton of unneeded crap in the abi folder which made the review pretty cumbersome too). I also added one comment about removing create2 in LBFactory, and some minor ones here and there.

I didn't look into the deploy scripts or tests too carefully.

[tjcloa]

just to push pending comments