fix: contract size limit #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcloa
reviewed
Aug 30, 2024
| import {ILBFlashLoanCallback} from "./ILBFlashLoanCallback.sol"; | ||
|
|
||
| interface ILBPairExt { | ||
| function swap(bool swapForY, address to) external returns (bytes32 amountsOut); |
There was a problem hiding this comment.
this function is one of the most used - pls move it back to the LBPair contract.
tjcloa
reviewed
Aug 30, 2024
Comment on lines
+11
to
+17
| function mint(address to, bytes32[] calldata liquidityConfigs, address refundTo) | ||
| external | ||
| returns (bytes32 amountsReceived, bytes32 amountsLeft, uint256[] memory liquidityMinted); | ||
|
|
||
| function burn(address from, address to, uint256[] calldata ids, uint256[] calldata amountsToBurn) | ||
| external | ||
| returns (bytes32[] memory amounts); |
There was a problem hiding this comment.
mint and burn are actively used by users that manage liquidity actively which is a common case with concentrated liquidity.
consider moving them back to the LBPair contract.
another way to reduce contract size is to set optimizer_runs in foundry.tomlto a lower value, e.g. 600.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.