unweave: Fix for MSVC 2022 ARM Preview probable compiler bug

See https://stackoverflow.com/questions/78608330/postfix-increment-compiler-bug-on-visual-studio-2022-arm-preview?noredirect=1#comment138587024_78608330
Dobiasd · Jun 11, 2024 · 34c88e3 · 34c88e3
1 parent ec0fb00
commit 34c88e3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/include/fplus/container_common.hpp b/include/fplus/container_common.hpp
@@ -1278,10 +1278,11 @@ std::pair<Container, Container> unweave(const Container& xs)
     auto it_odd = internal::get_back_inserter<Container>(result.second);
     std::size_t counter = 0;
     for (const auto& x : xs) {
-        if (counter++ % 2 == 0)
+        if (counter % 2 == 0)
             *it_even = x;
         else
             *it_odd = x;
+        counter++;
     }
     return result;
 }

diff --git a/include_all_in_one/include/fplus/fplus.hpp b/include_all_in_one/include/fplus/fplus.hpp
@@ -4373,10 +4373,11 @@ std::pair<Container, Container> unweave(const Container& xs)
     auto it_odd = internal::get_back_inserter<Container>(result.second);
     std::size_t counter = 0;
     for (const auto& x : xs) {
-        if (counter++ % 2 == 0)
+        if (counter % 2 == 0)
             *it_even = x;
         else
             *it_odd = x;
+        counter++;
     }
     return result;
 }