Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting CI check #293

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Formatting CI check #293

merged 3 commits into from
Dec 28, 2023

Conversation

offa
Copy link
Contributor

@offa offa commented Dec 28, 2023

As mentioned in #291.

This checks the formatting as part of the CI build.

I have added .clang-format and .clang-format-ignore files to keep the configuration same, no matter how it clang-format is invoked (CI, script, editor, …).

There were some minor formatting issues left, which are corrected too.

@Dobiasd
Copy link
Owner

Dobiasd commented Dec 28, 2023

Oh, what a beautiful solution. 🚀 Thanks a lot! ❤️

@Dobiasd Dobiasd merged commit 188b449 into Dobiasd:master Dec 28, 2023
20 checks passed
@Dobiasd
Copy link
Owner

Dobiasd commented Dec 28, 2023

Oh, sorry, you nicely separated the changes into 3 distinct commits, but I accidentally clicked "Squash and merge" instead of "Rebase and merge". 🦛 😶‍🌫️

@offa offa deleted the ci/format branch December 29, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants