Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE-THIS-FIRST] Load data into resume template and fix sync scheme #100

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

frankhart2018
Copy link
Member

@frankhart2018 frankhart2018 commented Apr 25, 2023

Closes #81
Closes #99

Implementation

  1. Implement a resume as a react component.
  2. Use the loaded resume from the redux state to fill in the react component as the data is filled in.
  3. Added reducers to update resume in the redux store.
  4. Update sync time between redux store and local storage to 3 seconds.
  5. Moved async sync function outside of Basics and into LeftPanel.
  6. All immediate updates now go to the redux store, this is done by simply replacing the calls to update local storage to redux reducer dispatch.
  7. All entries in the sample resume now update in real-time.

Note

@frankhart2018 frankhart2018 added the blocked Progress blocked label Apr 25, 2023
@frankhart2018
Copy link
Member Author

@dhairyaj Please also take a look at the CSS/Styling for this, fix those before merging this.

@frankhart2018 frankhart2018 added the high-priority This is high priority label Apr 25, 2023
@frankhart2018 frankhart2018 changed the title [DO-NOT-MERGE] Load data into resume template Load data into resume template Apr 27, 2023
@frankhart2018
Copy link
Member Author

@dhairyaj I have moved the styling issue for this to a new issue - #103. Please merge this after reviewing, this needs to be in master ASAP.

@frankhart2018 frankhart2018 changed the title Load data into resume template Load data into resume template and fix sync scheme Apr 27, 2023
@frankhart2018 frankhart2018 changed the title Load data into resume template and fix sync scheme [MERGE-THIS-FIRST] Load data into resume template and fix sync scheme Apr 27, 2023
Copy link
Member

@dhairyaj dhairyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhairyaj dhairyaj merged commit 0a0e9ac into master Apr 27, 2023
@frankhart2018 frankhart2018 deleted the in-81 branch April 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Progress blocked high-priority This is high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix data update scheme Push sample resume and fill with data
2 participants