address review

Doenet · Jul 9, 2024 · 711724f · 711724f
1 parent 50ebfd6
commit 711724f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/doenetml-prototype/src/renderers/components/point.tsx b/packages/doenetml-prototype/src/renderers/components/point.tsx
@@ -12,11 +12,11 @@ export const PointInGraph: BasicComponent<PointData> = ({ node }) => {
     const board = React.useContext(GraphContext);
     const pointRef = React.useRef<JSG.Point | null>(null);
 
-    let x = JSON.parse(
+    const x = JSON.parse(
         node.data.props.x.math_object,
         serializedComponentsReviver,
     ).evaluate_to_constant();
-    let y = JSON.parse(
+    const y = JSON.parse(
         node.data.props.y.math_object,
         serializedComponentsReviver,
     ).evaluate_to_constant();

diff --git a/packages/doenetml-worker-rust/lib-doenetml-core/src/core/props/prop_profile.rs b/packages/doenetml-worker-rust/lib-doenetml-core/src/core/props/prop_profile.rs
@@ -92,7 +92,7 @@ pub const fn prop_profile_to_type(profile: PropProfile) -> PropValueType {
         PropProfile::ListCodeNumber => PropValueType::String,
         PropProfile::Renderable => PropValueType::ComponentRef,
         PropProfile::RenderedChildren => PropValueType::AnnotatedContentRefs,
-        PropProfile::SplitSymbols => super::PropValueDiscriminants::Boolean,
+        PropProfile::SplitSymbols => super::PropValueType::Boolean,
         PropProfile::_Ref => PropValueType::ComponentRef,
         PropProfile::XrefLabel => PropValueType::XrefLabel,
         PropProfile::XrefDisplayContent => PropValueType::AnnotatedContentRefs,

diff --git a/packages/doenetml-worker-rust/lib-doenetml-core/src/core/state/types/math_expr.rs b/packages/doenetml-worker-rust/lib-doenetml-core/src/core/state/types/math_expr.rs
@@ -69,6 +69,7 @@ impl serde::Serialize for MathExpr {
     where
         S: serde::Serializer,
     {
+        // Serialize as a struct named `MathExpr` with `1` field: `math_object`
         let mut m = serializer.serialize_struct("MathExpr", 1)?;
         m.serialize_field("math_object", &self.math_object.0)?;
         m.end()