Add a <number> component #217
Conversation
| @@ -12,6 +12,8 @@ import { serializedComponentsReviver } from "@doenet/utils"; | |||
| import { Action, PointProps } from "@doenet/doenetml-worker-rust"; | |||
| import { useAppDispatch } from "../../state/hooks"; | |||
| import { coreActions } from "../../state/redux-slices/core"; | |||
| //@ts-ignore | |||
There was a problem hiding this comment.
This is a bit frustrating. Maybe we could re-export some typed versions of the functions that we're using?
There was a problem hiding this comment.
Sounds like a worthwhile goal. Seems overwhelming to me, so I could use some help getting started!
There was a problem hiding this comment.
I wasn't suggesting doing the whole thing. Just create and re-export the function you used in this file.
There was a problem hiding this comment.
Do you mean within DoenetML rather than in math-expressions? I could try that.
There was a problem hiding this comment.
I can only do that for a function that returns something simple like a number. The math expression object itself has a zillion attributes, so just describing that type would be non-trivial.
| use crate::general_prop::NumberToStringProp; | ||
| use crate::props::UpdaterObject; | ||
|
|
||
| /// The `<number>` component calculates a numerical value from its contents and display the result as text |
There was a problem hiding this comment.
Does it display fractions as well as decimals?
There was a problem hiding this comment.
No, it is an f64 representation, so only decimals. This is approximately equivalent to the legacy <number> component, which uses a Javascript Number. At this point, if you want fractions, you have to stick with <math>.
packages/doenetml-worker-rust/lib-doenetml-core/src/core/general_prop/math_prop.rs
Outdated
Show resolved
Hide resolved
This PR adds a
<number>component, updates the number and math props, and adds additional number, math, and point tests.