ability to have separate rendered props in a graph #220
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
packages/doenetml-worker-rust/lib-doenetml-core/src/components/doenet/_fragment.rs
Outdated
Show resolved
Hide resolved
packages/doenetml-worker-rust/lib-doenetml-core/src/components/doenet/point.rs
Outdated
Show resolved
Hide resolved
| // Determine whether or not component is in a graph (i.e., has a graph ancestor). | ||
| // If so, we'll look for props that are rendered `in_graph` rather than `in_text`. | ||
| let in_graph = document_structure | ||
| .get_true_component_ancestors(component_idx) |
There was a problem hiding this comment.
I don't recall what this function exactly does, but does the _true mean it ignores parents coming from extend? Please verify that this is actually the call we want.
There was a problem hiding this comment.
That's right. It gets the parent from the DAST and skips extra parents such as the component extended.
There was a problem hiding this comment.
But is that what we want? If we have a point in a graph and we extend that point outside of a graph, we want the one outside the graph to use the text renderer.
There was a problem hiding this comment.
That's right. That's what this should do, given that the "true" ancestors of the extended point will not include a graph. (In the dast, the extended point doesn't descend from a graph, though it does descend from a graph via its extended link from its source.)
I didn't rely on my understanding; I tested examples. I now made an automated test demonstrating this: rendered_props_with_references() inside the point tests. Let me know if there is another case I should consider.
There was a problem hiding this comment.
I understand now. We do want the true parent and not the inherited one! Tests give me confidence :-)
packages/doenetml-worker-rust/lib-rust-macros/src/component_module/items/props.rs
Outdated
Show resolved
Hide resolved
|
Looks good to go :-) |
This PR extends the
for_renderattribute on a prop so one can separately specify if the prop isfor_renderwhen the component is in a graph versus in text.The PR also adds a separate point renderer and rendered props when the point is not in a graph.