Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Review markup and selectors for the Notice component #849

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: Review markup and selectors for the Notice component #849

merged 1 commit into from
Nov 11, 2024

Conversation

rfgamaral
Copy link
Member

@rfgamaral rfgamaral commented Nov 11, 2024 •
edited
Loading

Short description

Follow-up to #848, so that the markup and selectors are more consistent with the Alert component.

PR Checklist

  • Executed npm run validate and made sure no errors / warnings were shown
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

n/a

@rfgamaral rfgamaral self-assigned this Nov 11, 2024
@rfgamaral rfgamaral merged commit 4db03bc into main Nov 11, 2024
5 checks passed
@rfgamaral rfgamaral deleted the ricardo/review-notice-markup-and-selectors branch November 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rfgamaral rfgamaral

Labels
Ship without review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rfgamaral