Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : To have only the sender's entity when sending mail #31053

Open
wants to merge 2 commits into
base: 18.0
Choose a base branch
from

Conversation

Thomas905
Copy link
Member

No description provided.

@eldy eldy added the Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them. label Sep 23, 2024
@lvessiller-opendsi
Copy link
Contributor

Thanks for your contribution.
First, you should fix the indentation code and commit again to resolve the pre-commit errors.
For me, it's not obvious to understand this FIX without description.
Could you give us more details and how to reproduce ?

Concerning the filter for user entity in SQL request, it's recommended to use "getEntity('user')" instead of "(0, $conf->entity)".
@hregis, is it right ?

@hregis
Copy link
Contributor

hregis commented Sep 26, 2024

@lvessiller-opendsi @Thomas905 this is a dictionary

getEntity('c_email_senderprofile')

Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for same solution as @hregis and @lvessiller-opendsi :-)
i discover that getentity can work with dictionnary

please update your commit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants