NEW Do not include cancelled orders in the billable filter #31119
Conversation
| @@ -941,6 +941,9 @@ | |||
| } | |||
| if ($search_billed != '' && $search_billed >= 0) { | |||
| $sql .= ' AND c.facture = '.((int) $search_billed); | |||
| if (getDolGlobalString('HIDE_CANCELLED_ORDERS_BILLABLE') == 1) { | |||
There was a problem hiding this comment.
If the user need both a filter on
billed
+
status of order that is not canceled.
The user can set the two filters to match its need. Why adding an option to replace silently a filter that should be already available to end user ?
There was a problem hiding this comment.
Logically, by definition, a cancelled order is not billable.
I had the same reaction as you when this remark was made to me in my company, but the secretary told me that it was a pain to have to select both the invoiced and the three statuses.
Especially as Dolibarr gives the wrong information, for me it's almost a bug fix, it's cancelled and can't be billed.
I've left the constant to let the user choose, but I think they should be hidden by default.
For example, our Dolibarr gives us €10,000 to invoice, but the reality is that we have a lot less to invoice and €10,000 in cancelled orders. The idea of the billable status is to see the backlog and be able to bill what I think is really billable.
There was a problem hiding this comment.
Having a filter that does not match the filter defined by user is a bug.
If user need to select 2 filters,this is an interface problem. And this must be fixed by interface changes.
Can you provide a screenshot of the page or menu where the secretary click before having to modify the filter ?
There was a problem hiding this comment.
There are other orders that I have removed for reasons of confidentiality.
Currently, as you suggested, you can use the “Status” filter, but it's a pain to select all three open statuses.
This seems to me to be a bug, since I think that in the majority of companies, a cancelled order is not billable.
The total amount is therefore not correct, the two cancelled orders need to be removed. Indeed, as you say, we could filter by status, but that would take longer and be illogical, I insist, there's a lack of consistency, in most cases we don't invoice a cancelled order.
The constant leaves the choice to those who want to bill them
There was a problem hiding this comment.
I see the filter "Billed" is already set correctly.
To reach this page, where does he/she click ? From the entry "Billlable orders" in the left menu ?
I check with last version of v19, v20 en develop and the filter "Status" that exclude draft order is correctly set automatically.
What is the version used ?
eldy
added
the
Discussion
NEW Do not include cancelled orders in the billable filter