-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sql queries #31154
Open
dolibarr95
wants to merge
5
commits into
Dolibarr:develop
Choose a base branch
from
dolibarr95:patch-74
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update sql queries #31154
+25
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the values : propal: $this->table_element propaldet : $this->table_element_line in the sql queries. see Dolibarr#31056
eldy
added
the
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
label
Sep 29, 2024
frederic34
reviewed
Sep 29, 2024
frederic34
reviewed
Sep 29, 2024
@@ -3973,7 +3973,7 @@ public static function replaceThirdparty(DoliDB $dbs, $origin_id, $dest_id) | |||
public static function replaceProduct(DoliDB $db, $origin_id, $dest_id) | |||
{ | |||
$tables = array( | |||
'propaldet' | |||
$this->$table_element_line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem
@frederic34 tks for your help. |
frederic34
reviewed
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the values :
propal: $this->table_element
propaldet : $this->table_element_line
in the sql queries.
see #31056