Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
#1 im a sysadmin, not a dev, so i am not very experienced with git and github procedures :)
#2 the JSON editor i am using (JSONBuddy) complains about the pattern for the filament name. i believe what i changed is the correct way to do it, but i am painfully aware that different validators work differently and the original pattern might have validated fine in others... still, if it doesn't break yours, i guess this is more "universal"
#3 the list for QIDI is not exhaustive, i just added those that i had ordered, will probably add more in the future
#4 what do you think about adding a "list price" to the definition? or was that left out on purpose?
thanks & kr