Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add QIDITech (PAHT|PPS)-CF #50

Merged
merged 1 commit into from
Nov 23, 2024
Merged

add QIDITech (PAHT|PPS)-CF #50

merged 1 commit into from
Nov 23, 2024

Conversation

mrambossek
Copy link
Contributor

hi,

#1 im a sysadmin, not a dev, so i am not very experienced with git and github procedures :)

#2 the JSON editor i am using (JSONBuddy) complains about the pattern for the filament name. i believe what i changed is the correct way to do it, but i am painfully aware that different validators work differently and the original pattern might have validated fine in others... still, if it doesn't break yours, i guess this is more "universal"

#3 the list for QIDI is not exhaustive, i just added those that i had ordered, will probably add more in the future

#4 what do you think about adding a "list price" to the definition? or was that left out on purpose?

thanks & kr

@Donkie
Copy link
Owner

Donkie commented Nov 23, 2024

Looks good, thank you.

List price is deliberately not included because it's just too variable between different countries, stores, sales, etc.

@Donkie Donkie merged commit 26c1d69 into Donkie:main Nov 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants