This repository has been archived by the owner on Dec 30, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of stuff is not working yet, so is this mostly for tracking progress.
Stylelint plugin is not compatible. The compatibility patch Add webpack4 support; webpack-contrib/stylelint-webpack-plugin#140 is not merged, and there does not seem to be any progress in the mentioned "rewrite". Potentially replace it.Recent update fixes compatibility.Done. Since the basic optimization is already applied via the style rules withmini-css-extract-plugin
as a replacement forextract-text-webpack-plugin
does not yet supportcontenthash
- PR for providing this viawebpack
core pending: add [contenthash] support webpack/webpack#6839.Seems to ignore its output path as wellMy mistake, config is slightly different compared to ETWP - fixed. On the other hand, ETWP does not supportwebpack
v4 yet and maybe never will.postcss
, additional optimizations viaoptimize-css-assets-webpack-plugin
have been hidden behind a config flag - they may break things or cause otherwise non-intended or -expected behavior, so they are too risky to be enabled by default.Suppose I won't need this anymore, since the updated setup generates ainline-chunk-manifest-html-webpack-plugin
caused issues as well. Pending PR is open here.runtime
chunk, which should supersed this.Is fixed with version 3.2.0.workbox-webpack-plugin
in v3 still causes a curious error likeTypeError: readFileFn is not a function
quite deep inside of it.Still attempting to point out why, since I already got this version working in myFigured it out: [workbox-webpack-plugin#InjectManifest] Relying on private _readFile is unstable GoogleChrome/workbox#1393 - a conjunction problem of thevue
playground.workbox
plugin and theAngularCompilerPlugin
.Suppose it's ok to stay with this for now.workbox-webpack-plugin
- in its current state, the handler injected viaInjectManifest
attempts to load modules that are not referenced in the service worker script. This only seems to happen using thelocal
import strategy, it does not happen usingcdn
. Check what can be done here -cdn
should be acceptable for quite a lot of circumstances, but not every.A couple of deprecation warnings are still raised in this version, but they don't seem to be problematic (at least for now).
Code and toolchain are ready to go, there are at least some docs to be updated:
longterm_caching_impact and references to it should be removed, since the config option got removed.