CPU profiling trace updates #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increased profiling trace coverage, notably with regards to function nodes - Added a MDFASTBINDING_CONDENSED_PROFILING directive to allow for a more 'compact' view of the trace events in the timeline (at the expense of some CPU cycles)
DoubleDeez
reviewed
Mar 29, 2024
|
|
||
| void UMDFastBindingDestinationBase::InitializeDestination(UObject* SourceObject) | ||
| { | ||
| #if defined(MDFASTBINDING_CONDENSED_PROFILING) && MDFASTBINDING_CONDENSED_PROFILING |
There was a problem hiding this comment.
Instead of checking for MDFASTBINDING_CONDENSED_PROFILING all over, could you change all the instances to always use MD_TRACE_CPUPROFILER_EVENT_SCOPE_FUNCTION_TEXT and then #define it based on MDFASTBINDING_CONDENSED_PROFILING in MDFastBindingTraceHelpers.h?
I think it ends up being cleaner that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDFASTBINDING_CONDENSED_PROFILINGdirective to allow for a more 'compact' view of the trace events in the timeline (at the expense of some CPU cycles)Note that
MDFASTBINDING_CONDENSED_PROFILINGis disabled by default to maintain existing behavior, but it has helped reduce a lot of clutter and depth in the timeline graph. I'll leave it up to you on whether it's worth enabling by default (at the expense of the trace's absolute performance cost).