Attempting to enable the production branch_type never seems to get "fixed" #208
Conversation
| @@ -311,6 +311,7 @@ func flattenBranchModel(rp *BranchModel, typ string) []interface{} { | |||
| "is_valid": rp.IsValid, | |||
| "use_mainbranch": rp.UseMainbranch, | |||
| "name": rp.Name, | |||
| "enabled": rp.Enabled, | |||
There was a problem hiding this comment.
For production, the BitBucket API returns an enabled field. We simply need to copy it from the BranchModel to the output. In the develop case, the enabled field is not present in the response and defaults to false. NOTE: In the develop case, the enabled field is also not part of the Terraform resource schema.
In light of the above, I'm not 100% sure about this fix. It seems a little hacky. Another potential option is to handle the enabled field of production separately so it doesn't affect development. Thoughts?
|
@DrFaust92: Do you think you will have time to review this PR soon? No particular rush, but once this is (hopefully) merged and released, all the provider bugs affecting us at Zoro will have been fixed and we'll upgrade. 😌 Thank you. 🙏🏽 |
|
Thank you!! |
Fixes #207