Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vibration for SDK >= 33 #1833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

and-fed
Copy link

@and-fed and-fed commented Nov 23, 2024

Vibration doesn't work on Android 14 for incoming calls on Xiaomi (HyperOS) devices. It was tested on POCO X6 PRO, Xiaomi 14T. Incoming call is visible on screen, ringtone works fine, but vibration doesn't work at all in all modes.

After further investigation using debugger, I found that "vibrator.vibrate" method doesn't work. I added fork to handle Android 13+ (>= SDK 33) differently using recommended method from Android documentation.

I realize the deprecated method should work fine, but looks like not all vendors support it correctly. By my pull request I propose to improve the current vibration logic by using recommended method and, as the result, fix the bug on wide range of devices.

Also found very similar, if not same, bug for other phone owners in this bug report topic:
https://bugs.telegram.org/c/2569

@and-fed
Copy link
Author

and-fed commented Nov 30, 2024

@dkaraush Any idea when it can be reviewed?

@gmk57
Copy link

gmk57 commented Dec 31, 2024

Similar issue reported for Samsung devices: https://bugs.telegram.org/c/43817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants