#3 handle accents and a few cosmetic changes #12
Conversation
…nd line switches ands special cases, in English and French.
- needs recent build.gradle of jnativehook - needs unicode encoded source files Also fixed the way chars are recorded (must be via method)nativeKeyTyped And also fixed the way backspace (and other control chars) was (might have been) implemented Fixed UT that remained strict
� Conflicts: � src/main/java/fr/raluy/chocoratage/Config.java
|
I didn't change much. The main change is the way keyCodes and keyChars are analyzed. What you were doing (getKeyText) was some sort of (unintentional?) workaround for the (poorly documented) way NativeKeyEvents are contextualized. Now we're as neat as Mr. Clean (plus I nearly have the same amount of hair). |
|
Hey, I cant build the project because I'm missing jnativehook-2.1.1-SNAPSHOT.jar |
|
Unzip it, github refuses to include jars (which are zips, go figure) |
|
Hi Fabien, I'm on sick leave today and I plan on reviewing this PR. There are some things in the code that bothers me, amomgst them new README. How open are you to changes? As you are the main contributor right now, I dont feel like its right for me to play the dictator, but on the other hand I can't host and maintain stuff I don't believe in. |
|
Huh sounds like serious matter. |
|
Nothing serious, dont' worry :) I don't take myself or this project too seriously. Let me make some changes to your PR and submit them to you, it'll be easier. |
| if (Config.isDebugMode()) { | ||
| log.info("OS set to {}", os); | ||
| log.info("Forbidden phrases:", os); |
There was a problem hiding this comment.
It's a bad case of copy paste, there's not even a {}. Should be log.info("Forbidden phrases:");
This comment has been minimized.
This comment has been minimized.
|
I cannot get the program to work, be it using the command line or the IDE.
When running the jar I get the error at this line: GlobalScreen.registerNativeHook(); Any idea? |
|
Could you test it on a Debian VM? It seems to me this version of jnativehook crashes. |
|
Ah damn, I realize the jar I gave you was a quick compile on windows (yes I develop this on windows, sometimes Ubuntu shame on me). On any other OS you'll miss the native lib (.so...). |
|
jnativehook-2.1.20200213.zip |
|
Thx a lot :) And no need to apologize :) |
#3 handle accents and a few cosmetic changes