Fix #425: using setDefaultNightMode

[anandwana001]

Issue

• close Drawable-night is not accessible #425

Overview (Required)

• Using of setDefaultNightMode

Links

Screenshot

Before	After

This also solving #344

[anandwana001]

@takahirom Please let me know, if this is a correct approach to fix this issue.

[takahirom]

I think there are good and bad things, but since the ViewModel will be in the form of directly operating the View, how about doing the following?

class MainActivity : AppCompatActivity() {
    private val appViewModel by viewModels<RealAppViewModel>()
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        WindowCompat.setDecorFitsSystemWindows(window, false)
        setup()
        appViewModel.state
            .onEach {
// ...
            }
            .launchIn(lifecycleScope)
    }

[anandwana001]

Using setDefaultNightMode will lead into activity recreation - https://medium.com/androiddevelopers/appcompat-v23-2-daynight-d10f90c83e94

Twitter - https://twitter.com/Guardiola31337/status/1098938208954519554

[takahirom]

I'll take a look tomorrow 👀

[takahirom]

Now Activity is receated by config changes such as screen rotation. So that's fine.
Thank you for teaching me. 👍

[takahirom]

Thank you for raising the issue and solving it! 👍