remove unnecessary parameters

DroidKaigi · Sep 2, 2023 · ae30313 · ae30313
1 parent 168c7f8
commit ae30313
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/app-ios/Modules/Sources/Contributor/ContributorView.swift b/app-ios/Modules/Sources/Contributor/ContributorView.swift
@@ -13,9 +13,6 @@ public struct ContributorView: View {
     public var body: some View {
         ContributorComposeView(
             viewModel.getRepositoryForCompose(),
-            onNavigationIconClick: {
-
-            },
             onContributorItemClick: { contributorUrl in
                 presentingURL = IdentifiableURL(string: contributorUrl)
             }
@@ -36,20 +33,16 @@ public struct ContributorView: View {
 
 struct ContributorComposeView: UIViewControllerRepresentable {
     let contributorsRepository: ContributorsRepository
-    let onNavigationIconClick: () -> Void
     let onContributorItemClick: (String) -> Void
 
-    init(_ contributorsRepository: ContributorsRepository, onNavigationIconClick: @escaping () -> Void, onContributorItemClick: @escaping (String) -> Void) {
+    init(_ contributorsRepository: ContributorsRepository, onContributorItemClick: @escaping (String) -> Void) {
         self.contributorsRepository = contributorsRepository
-        self.onNavigationIconClick = onNavigationIconClick
         self.onContributorItemClick = onContributorItemClick
     }
 
     func makeUIViewController(context: Context) -> UIViewController {
         let vc = DarwinContributorsKt.contributorViewController(
             contributorsRepository: contributorsRepository,
-            isTopAppBarHidden: true,
-            onNavigationIconClick: onNavigationIconClick,
             onContributorItemClick: onContributorItemClick
         )
         vc.overrideUserInterfaceStyle = .light

diff --git a/.../src/iosMain/kotlin/io/github/droidkaigi/confsched2023/contributors/DarwinContributors.kt b/.../src/iosMain/kotlin/io/github/droidkaigi/confsched2023/contributors/DarwinContributors.kt
@@ -3,17 +3,13 @@ package io.github.droidkaigi.confsched2023.contributors
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.ui.interop.LocalUIViewController
 import androidx.compose.ui.window.ComposeUIViewController
-import io.github.droidkaigi.confsched2023.data.contributors.DefaultContributorsRepository
-import io.github.droidkaigi.confsched2023.data.contributors.FakeContributorsApiClient
 import io.github.droidkaigi.confsched2023.model.ContributorsRepository
 import io.github.droidkaigi.confsched2023.ui.UserMessageStateHolderImpl
 import platform.UIKit.UIViewController
 
 @Suppress("UNUSED")
 fun contributorViewController(
     contributorsRepository: ContributorsRepository,
-    isTopAppBarHidden: Boolean,
-    onNavigationIconClick: () -> Unit,
     onContributorItemClick: (url: String) -> Unit,
 ): UIViewController = ComposeUIViewController {
     val viewModel = ContributorsViewModel(
@@ -29,8 +25,8 @@ fun contributorViewController(
 
     ContributorsScreen(
         viewModel = viewModel,
-        isTopAppBarHidden = isTopAppBarHidden,
-        onNavigationIconClick = onNavigationIconClick,
+        isTopAppBarHidden = true,
+        onNavigationIconClick = { /** no action for iOS side **/ },
         onContributorItemClick = onContributorItemClick,
     )
 }