Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Add a bottom padding to the floor map #1027

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[iOS] Add a bottom padding to the floor map #1027

merged 1 commit into from
Aug 30, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Aug 30, 2023

Issue

  • close N/A

Overview (Required)

  • The side events on the floor map are partially hidden under the footer button.
    This PR adds a bottom padding and resolves that.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@woxtu woxtu requested a review from a team as a code owner August 30, 2023 00:28
ry-itto
ry-itto approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@ry-itto ry-itto merged commit 3602464 into DroidKaigi:main Aug 30, 2023
4 checks passed
@woxtu woxtu deleted the floor-map branch August 31, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woxtu @ry-itto