Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Support Achievement Rally with NFC #1110

Merged
merged 11 commits into from
Sep 9, 2023
Merged

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Sep 6, 2023

Issue

  • close #ISSUE_NUMBER

Overview (Required)

  • Support Achievement Rally on iOS
    • with NFC
    • with DeepLink

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

Recording of "Electriic Eel" achievement.

RPReplay_Final1694279607.MP4

@ry-itto ry-itto requested a review from a team as a code owner September 6, 2023 18:32
@woxtu
Copy link
Contributor

woxtu commented Sep 6, 2023

Awesome!

Copy link
Contributor

@tkhs0604 tkhs0604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

}
Button {
Task {
let result = await viewModel.read()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we need an action just before reading NFC tags 👀

@ry-itto
Copy link
Member Author

ry-itto commented Sep 9, 2023

Sorry I have some work left to do, so I'll make it a draft.

@ry-itto ry-itto marked this pull request as draft September 9, 2023 16:02
@ry-itto ry-itto self-assigned this Sep 9, 2023
@ry-itto ry-itto marked this pull request as ready for review September 9, 2023 17:21
@ry-itto ry-itto merged commit 5835b6e into main Sep 9, 2023
5 checks passed
@ry-itto ry-itto deleted the ios-add-dynamic-links-nfc branch September 9, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants