Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Correctly indicated that the third day room is on the first floor, not the basement. #1120

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

Corvus400
Copy link
Contributor

Issue

Overview (Required)

  • The room on the third day will be the room where D and E are combined.

Links

Movie (Optional)

Before After
before.mp4
after.mp4

…not the basement.

The room on the third day will be the room where D and E are combined.
https://twitter.com/mhidaka/status/1700079778643198299
@Corvus400 Corvus400 requested a review from a team as a code owner September 8, 2023 10:47
Comment on lines +24 to +25
// The color of D is set as workaround.
RoomDE -> colors.hallD
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to assign a room color for the third day or a gradient color for D and E if possible, but I have decided that it is not advisable to make major changes to this structure now.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Test Results

215 tests   215 ✔️  6m 54s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 6edbce3.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 8, 2023 11:24 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better than what we have now! Thanks!

@takahirom takahirom merged commit 40a4bb8 into DroidKaigi:main Sep 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants