Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] 🔧 The numerical value where cornerRadius is currently assigned is replaced by the defined Radius value. #1199

Merged
merged 5 commits into from
Sep 14, 2023
Merged

[iOS] 🔧 The numerical value where cornerRadius is currently assigned is replaced by the defined Radius value. #1199

merged 5 commits into from
Sep 14, 2023

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 12, 2023 •
edited
Loading

Issue

Overview (Required)

  • The title says it all.
  • I omitted the video because I simply replaced the same values...should I add them? 🤔

@Corvus400 Corvus400 marked this pull request as ready for review September 12, 2023 16:36
@Corvus400 Corvus400 requested a review from a team as a code owner September 12, 2023 16:36
@Corvus400 Corvus400 changed the title 🔧 The numerical value where cornerRadius is currently assigned is replaced by the defined Radius value. [iOS] 🔧 The numerical value where cornerRadius is currently assigned is replaced by the defined Radius value. Sep 12, 2023
ry-itto
ry-itto approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍🏼

@ry-itto
Copy link
Member

ry-itto commented Sep 13, 2023

@Corvus400
Sorry, this PR is conflicted.. Please fix this 🙇🏼

@Corvus400
Copy link
Contributor Author

@ry-itto
I'll fix it during lunch time at Droidkaigi 🍱.

@Corvus400
Copy link
Contributor Author

@ry-itto
I arrived at the venue and had extra time to resolve the code conflicts.
Please merge when you are free. 🙏

@ry-itto ry-itto merged commit c420997 into DroidKaigi:main Sep 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Use the defined Radius on each screen.
2 participants
@Corvus400 @ry-itto