Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add retry support to NFCReader #1206

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

treastrain
Copy link
Contributor

Overview (Required)

  • In the part of iOS that uses NFCReader, add a process that prompts the user to retry when an unexpected NFC tag is scanned.
    • To do so, use NFCTagReaderSession instead of NFCNDEFReaderSession.
      • NFC tags assume that ISO 14443 (NFC-A) NDEF messages are used.
    • To determine if the URL contained in the data inside the NFC tag is the intended one, add NFCReader.urlResolver and use it.
  • Add the ability to enable/disable the scan start button to prevent users from tapping the button again to start scanning while scanning is in progress.
    • This prevents errors that often occur when using Core NFC on iOS, where system resources become unavailable.

Movie (Optional)

After
treastrain_nfc-reader.mp4
In this movie, the intended tag is scanned after two incorrect NFC tags are scanned.

@treastrain treastrain requested a review from a team as a code owner September 12, 2023 21:24
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your improvement!
I think Achieve Rally experience is absolutely improved!

@ry-itto ry-itto merged commit d12ebd0 into DroidKaigi:main Sep 13, 2023
4 checks passed
@treastrain treastrain deleted the nfc-reader branch September 13, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants