Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix/#1237] achievements image size issue #1247

Merged
merged 13 commits into from
Sep 29, 2023
Merged

[fix/#1237] achievements image size issue #1247

merged 13 commits into from
Sep 29, 2023

Conversation

gy6543721
Copy link
Contributor

@gy6543721 gy6543721 commented Sep 16, 2023 •
edited
Loading

Issue

Overview (Required)

  • Fix achievements image size inconsistency issue

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After
截圖 2023-09-16 13 04 05 截圖 2023-09-16 15 58 20

@gy6543721 gy6543721 requested a review from a team as a code owner September 16, 2023 04:31
@gy6543721 gy6543721 changed the title Fix/#1237 achievements image size issue [fix/#1237] achievements image size issue Sep 16, 2023
@gy6543721 gy6543721 mentioned this pull request Sep 16, 2023
Closed
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 05:42 Inactive
@github-actions
Copy link

github-actions bot commented Sep 16, 2023 •
edited
Loading

Test Results

216 tests   216 ✔️  10m 9s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 33efe29.

♻️ This comment has been updated with latest results.

@takahirom
Copy link
Member

It seems that it will be big 👀
image

@gy6543721
Copy link
Contributor Author

gy6543721 commented Sep 16, 2023 •
edited
Loading

It seems that it will be big 👀 image

Fixed and updated.

@DroidKaigi DroidKaigi deleted a comment from github-actions bot Sep 16, 2023
@github-actions
Copy link

Snapshot diff report

File name Image
AchievementsScreenTe
st.checkLaunchShot_c
ompare.png
AchievementsScreenTe
st.checkLaunchShot_2
_compare.png
KaigiAppTest.checkNa
vigateToAchievements
Shot_compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 07:32 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 18, 2023 10:28 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 27, 2023 11:57 Inactive
@gy6543721
Copy link
Contributor Author

@takahirom
May I ask is there anyone reviewing this PR ?
There's no update for a long time.
Problem solved and need someone to approve for merging, thanks.

takahirom
takahirom approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late. looks great!

@takahirom takahirom merged commit 1a9febb into DroidKaigi:main Sep 29, 2023
8 checks passed
@gy6543721 gy6543721 deleted the fix/#1237-achievements-image-size-issue branch October 2, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

@mhidaka mhidaka Awaiting requested review from mhidaka mhidaka is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Electric eel is a little bigger on Achievements screen
2 participants
@gy6543721 @takahirom