Make the description of achivements operable by Firebase Remote Config #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringの取得に対応
詳細の文言の固定の値を削除
詳細の文言をFirebaseから取得
取得間隔を調整
初期化ロジックを変更
軽微な変更
不要なログの削除
|
Hi @momomomo111! Codes seem to be unformatted. To resolve this issue, please run |
リンターによる修正
初期化方法の変更
初期化方法の変更
momomomo111
changed the title
|
Snapshot diff report
|
takahirom
reviewed
Aug 29, 2023
Comment on lines
35
to
38
| stamps: ImmutableList<Stamp>, | ||
| detailDescription: String, | ||
| @androidx.annotation.RawRes | ||
| stampLottieRawId: Int?, |
There was a problem hiding this comment.
In our policy, we want to have UiState for sections.
But we might not have time. So I'll leave it to you
https://github.com/DroidKaigi/conference-app-2023#section
There was a problem hiding this comment.
I did indeed miss it.
I have corrected it in the following commit
StampListUiStateでデータクラス作成
RemoteConfigApiImplのswift側を実装
takahirom
reviewed
Aug 29, 2023
| @@ -30,8 +30,13 @@ private const val StampListColumns = 2 | |||
| private const val SingleItemSpanCount = 2 | |||
| private const val DoubleItemSpanCount = 2 / 2 | |||
|
|
|||
| data class StampListUiState( | |||
| val detailDescription: String, | |||
There was a problem hiding this comment.
I hoped it includes stamps: ImmutableList<Stamp> as well. But it is ok
takahirom
approved these changes
Aug 29, 2023
stampの置き場所を変更
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview (Required)
Screenshot (Optional if screenshot test is present or unrelated to UI)