-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the description of achivements operable by Firebase Remote Config #987
Conversation
stringの取得に対応
詳細の文言の固定の値を削除
詳細の文言をFirebaseから取得
取得間隔を調整
初期化ロジックを変更
軽微な変更
不要なログの削除
Hi @momomomo111! Codes seem to be unformatted. To resolve this issue, please run |
リンターによる修正
初期化方法の変更
初期化方法の変更
Snapshot diff report
|
stamps: ImmutableList<Stamp>, | ||
detailDescription: String, | ||
@androidx.annotation.RawRes | ||
stampLottieRawId: Int?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our policy, we want to have UiState for sections.
But we might not have time. So I'll leave it to you
https://github.com/DroidKaigi/conference-app-2023#section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did indeed miss it.
I have corrected it in the following commit
StampListUiStateでデータクラス作成
RemoteConfigApiImplのswift側を実装
@@ -30,8 +30,13 @@ private const val StampListColumns = 2 | |||
private const val SingleItemSpanCount = 2 | |||
private const val DoubleItemSpanCount = 2 / 2 | |||
|
|||
data class StampListUiState( | |||
val detailDescription: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hoped it includes stamps: ImmutableList<Stamp>
as well. But it is ok
stampの置き場所を変更
Overview (Required)
Screenshot (Optional if screenshot test is present or unrelated to UI)