-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement all properties for TokenIntrospectionResponse optional claims #55
base: main
Are you sure you want to change the base?
Implement all properties for TokenIntrospectionResponse optional claims #55
Conversation
07c9fad
to
731cd48
Compare
37e0dfa
to
979497f
Compare
🎉 All tests are finally green ✅! |
979497f
to
a11fd24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to remove the use of Lazy
in this PR. That way, developers can make their own choice about if they need Lazy access to these properties. My guess is that in practice, there wouldn't be much gained by not evaluating the properties when they're not needed, and depending on access patterns, the allocations needed by Lazy
and the locking it does to provide thread safety might introduce other overhead. If we leave it out of the library, then individual applications can always add whatever optimizations they want.
ea65138
to
2a8c7d4
Compare
Fair point. Addressed in f75f651. |
As described by [RFC 7662 - OAuth 2.0 Token Introspection][1] [1]: https://datatracker.ietf.org/doc/html/rfc7662
2a8c7d4
to
f75f651
Compare
I just rebased this pull request on the I also slightly modified how the |
84f02f1
to
c01e68b
Compare
As described by RFC 7662 - OAuth 2.0 Token Introspection
(Taking over IdentityModel/IdentityModel#577 to the new repository, adapted to the new
Duende.IdentityModel
namespace.)