atm - Make sure sync method of access token handler is not invoked #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erwinvandervalk
added
area/access-token-management
josephdecock
approved these changes
Feb 6, 2025
Erwinvandervalk
force-pushed
the
ev/sync-access-token-handler
branch
from
98aacaa to
679a4e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
The Send() method of the AccessTokenHandler now fails with a NotSupportedException, rather than fail silently.
The synchronous Send() method of the access token handler was never implemented. Calling it would cause it to do nothing. Unfortunately we can't implement this method, because we're calling into other asynchronous code. We also can't implement it by calling .GetAwaiter().GetResult() as this might have many negative side effects such as deadlocks.
The origin of this issue is that the SendAsync() was already present in .Net core 1.0 but the Send method was introduced later.
fixes: #28