Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.3 on CI #697

Merged
merged 13 commits into from
Dec 31, 2023
Merged

Add Ruby 3.3 on CI #697

merged 13 commits into from
Dec 31, 2023

Conversation

andrykonchin
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6d53f10) 90.35% compared to head (13cce10) 90.32%.

Files Patch % Lines
...dynamoid/adapter_plugin/aws_sdk_v3/create_table.rb 0.00% 2 Missing ⚠️
lib/dynamoid/persistence/save.rb 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
- Coverage   90.35%   90.32%   -0.03%     
==========================================
  Files          62       62              
  Lines        3162     3154       -8     
==========================================
- Hits         2857     2849       -8     
  Misses        305      305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrykonchin andrykonchin changed the title Add Ruby 3 3 on CI Add Ruby 3.3 on CI Dec 31, 2023
@andrykonchin andrykonchin force-pushed the ak/add-ruby-3-3-on-ci branch 4 times, most recently from 4fde8a2 to 882bd66 Compare December 31, 2023 23:03
Error:

```
RuntimeError:
  Unable to find a compatible xml library. Ensure that you have installed or added to your Gemfile one of ox, oga, libxml, nokogiri or rexml
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core/xml/parser.rb:74:in `set_default_engine'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core/xml/parser.rb:96:in `<class:Parser>'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core/xml/parser.rb:7:in `<module:Xml>'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core/xml/parser.rb:5:in `<module:Aws>'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core/xml/parser.rb:3:in `<top (required)>'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core/xml.rb:8:in `require_relative'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core/xml.rb:8:in `<top (required)>'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core.rb:77:in `require_relative'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-core-3.190.1/lib/aws-sdk-core.rb:77:in `<top (required)>'
# ./vendor/bundle/ruby/3.2.0/gems/aws-sdk-dynamodb-1.98.0/lib/aws-sdk-dynamodb.rb:11:in `<top (required)>'
# ./lib/dynamoid.rb:3:in `<top (required)>'
```
Copy link

Code Coverage

Package Line Rate Health
dynamoid 90%
Summary 90% (2849 / 3154)

Minimum allowed line rate is 90%

@andrykonchin andrykonchin marked this pull request as ready for review December 31, 2023 23:19
@andrykonchin andrykonchin merged commit 7104dca into master Dec 31, 2023
58 of 60 checks passed
@andrykonchin andrykonchin deleted the ak/add-ruby-3-3-on-ci branch December 31, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant