Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: multi-instance and nbfb testing #6984

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Feb 7, 2025

Adding support for multi-instance capability in EAMxx (a one-liner in mct coupling layer) and adding a customized/specialized MVK tests for climate/nbfb reproducibility in EAMxx. More details to come.

[BFB]

@mahf708 mahf708 added the EAMxx PRs focused on capabilities for EAMxx label Feb 7, 2025
@mahf708 mahf708 requested a review from mkstratos February 7, 2025 21:23
Copy link

github-actions bot commented Feb 7, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://E3SM-Project.github.io/E3SM/pr-preview/pr-6984/

Built to branch gh-pages at 2025-02-07 21:25 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@mahf708 mahf708 requested a review from rljacob February 7, 2025 22:23
@mahf708
Copy link
Contributor Author

mahf708 commented Feb 7, 2025

To trigger:

./cime/scripts/create_test MVKxx_Ly1.ne4pg2_ne4pg2.F2010-SCREAMv1.chrysalis_gnu.eamxx-mvkpert --generate --baseline-root=/lcrc/group/e3sm/ac.ngmahfouz/baselines -b new -o --wait
./cime/scripts/create_test MVKxx_Ly1.ne4pg2_ne4pg2.F2010-SCREAMv1.chrysalis_gnu.eamxx-mvkpert --compare --baseline-root=/lcrc/group/e3sm/ac.ngmahfouz/baselines -b new -o --wait

I aim to integrate this next week. It seems to be working fine. We [EAMxx Eval team] will validate it so that we can potentially adopt as the official nbfb/climate reproducibility test


I will use this comment to make keep a record of some notes:

  • We really need to address EAMxx: settle on IO naming scheme #6822 in the near future because we do a lot of cute dance around it; one of my motivations in documenting that issue and pushing for it is because I want us to peacefully go in and out for the ancient CIME/EAM/etc. infrastructure without having to walk on eggshells and do all sorts of customizations to get stuff going. One day when another revolution happens in the coupler and/or CIME, we can think about reinventing stuff, but for now, I think we should just use it and spare our cycles for other things we care about ...

@@ -323,6 +324,7 @@
<values>
<value component="any">$CIMEROOT/CIME/SystemTests</value>
<value component="mpaso">$COMP_ROOT_DIR_OCN/cime_config/SystemTests</value>
<value component="scream">$COMP_ROOT_DIR_ATM/cime_config/SystemTests</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds eamxx/cime_config/SystemTests to the CIME software?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know exactly, but this enables us to define new tests, namely MVKxx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, after talking to @mkstratos; I think we will move most of these overrides here to EVV module. Either before or after integrating this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants