Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring various DPxx options out to the namelist #2803

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

bogensch
Copy link
Contributor

Brings various DPxx related options out the namelist to allow modification at runtime.

@bogensch bogensch added BFB Bit for bit AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass SCREAMv1 DP-SCREAM labels Apr 29, 2024
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/scream/pr-preview/pr-2803/
on branch gh-pages at 2024-04-29 23:48 UTC

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5308
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;AT: AUTOMERGE;SCREAMv1;DP-SCREAM
PULLREQUESTNUM 2803
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA a2a9f5c
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 0dc389b
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 5630
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;AT: AUTOMERGE;SCREAMv1;DP-SCREAM
PULLREQUESTNUM 2803
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA a2a9f5c
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 0dc389b
TEST_REPO_ALIAS SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)
  • Branch: bogensch/DPxx_namelist
  • SHA: a2a9f5c
  • Mode: TEST_REPO

Pull Request Author: bogensch

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5308
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;AT: AUTOMERGE;SCREAMv1;DP-SCREAM
PULLREQUESTNUM 2803
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA a2a9f5c
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 0dc389b
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 5630
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS BFB;AT: AUTOMERGE;SCREAMv1;DP-SCREAM
PULLREQUESTNUM 2803
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA a2a9f5c
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 0dc389b
TEST_REPO_ALIAS SCREAM

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@E3SM-Autotester
Copy link
Collaborator

All Jobs Finished; status = PASSED, target_sha=0dc389b4d65ea312fd7cf5005f8278ceb9b15811, However Inspection must be performed before merge can occur...

@tcclevenger tcclevenger removed the AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass label Apr 30, 2024
Copy link
Contributor

@tcclevenger tcclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed automerge in case you wanted to make more changes before requesting reviews. But this looks good to me, I should have added them on my last PR. We could also make case-specific options, but that will depend on how we want to set up the compsets.

@E3SM-Autotester
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@bogensch
Copy link
Contributor Author

Thanks @tcclevenger; this is good to go in so I'll re-issue the auto merge.

@bogensch bogensch added the AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass label Apr 30, 2024
@E3SM-Autotester E3SM-Autotester merged commit 305bde7 into master Apr 30, 2024
9 checks passed
@E3SM-Autotester E3SM-Autotester deleted the bogensch/DPxx_namelist branch April 30, 2024 15:41
@E3SM-Autotester E3SM-Autotester removed the AT: AUTOMERGE Inform the autotester (AT) that it can merge this PR if reviewers approved, and tests pass label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants